[
https://issues.apache.org/jira/browse/GOBBLIN-1617?focusedWorklogId=737036&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-737036
]
ASF GitHub Bot logged work on GOBBLIN-1617:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 05/Mar/22 07:07
Start Date: 05/Mar/22 07:07
Worklog Time Spent: 10m
Work Description: aditya-narain-gupta commented on a change in pull
request #3475:
URL: https://github.com/apache/gobblin/pull/3475#discussion_r820058818
##########
File path:
gobblin-core/src/main/java/org/apache/gobblin/writer/FsDataWriter.java
##########
@@ -96,7 +97,7 @@ public FsDataWriter(FsDataWriterBuilder<?, ?> builder, State
properties) throws
this.writerAttemptIdOptional =
Optional.fromNullable(builder.getWriterAttemptId());
this.encoders = builder.getEncoders();
- Configuration conf = new Configuration();
+ this.conf = new Configuration();
Review comment:
We can populate the conf object with the properties passed in the
constructor so that users can pass on custom configs like for Trash / File
System-
`this.conf = HadoopUtils.getConfFromProperties(properties);`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 737036)
Remaining Estimate: 0h
Time Spent: 10m
> pass job configurations to HaddopUtils API
> ------------------------------------------
>
> Key: GOBBLIN-1617
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1617
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Arjun Singh Bora
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
