[
https://issues.apache.org/jira/browse/GOBBLIN-1634?focusedWorklogId=763214&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-763214
]
ASF GitHub Bot logged work on GOBBLIN-1634:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 28/Apr/22 00:34
Start Date: 28/Apr/22 00:34
Worklog Time Spent: 10m
Work Description: phet commented on PR #3495:
URL: https://github.com/apache/gobblin/pull/3495#issuecomment-1111610946
> Functionally speaking it's just a cancellation event which isn't user
initiated that doesn't have the flag that it was killed due to exceeding the
start/runtime SLA
would it be worth adding a comment when preparing that internal cancellation
saying that it won't be retried because it's missing the flag?
per our conversation recently about 'semantic naming', we could always
consider naming that flag something like:
```
- public static final String IS_FLOW_SLA_KILLED = "isFlowSlaKilled";
+ public static final String DOES_CANCELED_FLOW_MERIT_RETRY =
"doesCanceledFlowMeritRetry";
```
?
Issue Time Tracking
-------------------
Worklog Id: (was: 763214)
Time Spent: 1h (was: 50m)
> GaaS Flow SLA Kills should be retryable if configured
> -----------------------------------------------------
>
> Key: GOBBLIN-1634
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1634
> Project: Apache Gobblin
> Issue Type: Task
> Reporter: William Lo
> Priority: Major
> Time Spent: 1h
> Remaining Estimate: 0h
>
> On Gobblin as a Service flows can fail SLAs if they do not receive a Kafka
> event in some designated amount of time.
> Since GaaS supports retrys on failures, these failures due to SLAs should
> also be retryable.
> However, if the flow is cancelled from a user specified event through the API
> we do not want to retry.
> Additionally, we also do not want to retry if a flow is skipped due to
> concurrent jobs running at the same time, as it is unlikely without a more
> sophisticated waiting algorithm that the job will be finished by the time the
> job is retried again, wasting resources.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
