[
https://issues.apache.org/jira/browse/GOBBLIN-1637?focusedWorklogId=763932&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-763932
]
ASF GitHub Bot logged work on GOBBLIN-1637:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 28/Apr/22 23:32
Start Date: 28/Apr/22 23:32
Worklog Time Spent: 10m
Work Description: jack-moseley opened a new pull request, #3498:
URL: https://github.com/apache/gobblin/pull/3498
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I
have checked off all the steps below!
### JIRA
- [x] My PR addresses the following [Gobblin
JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references
them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-1637
### Description
- [x] Here are some details about my PR, including screenshots (if
applicable):
- Add info of which metadata writer failed in the failure events
- Add which operation type failed. To do this, split up the events so that
there's a separate event if opType changes, otherwise the event offset ranges
could contain multiple different offsets
- Add which partition values were intended to be added/dropped as part of
these GMCE. To do this added a
`HiveMetadataWriterWithPartitionInfoException.java` only thrown from hive
writer in order to pass partition info back to MCE Writer
- Fix bug in hive metadata writer where failure in flush would throw
RuntimeException, but catch block only catches IOException so fault tolerant
behaviour would never work for flush failures
### Tests
- [x] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
Tested in test pipeline
### Commits
- [x] My commits all reference JIRA issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
Issue Time Tracking
-------------------
Worklog Id: (was: 763932)
Remaining Estimate: 0h
Time Spent: 10m
> Add writer, operation, and partition info to failed metadata writer events
> --------------------------------------------------------------------------
>
> Key: GOBBLIN-1637
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1637
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Jack Moseley
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
