[
https://issues.apache.org/jira/browse/GOBBLIN-1648?focusedWorklogId=773646&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-773646
]
ASF GitHub Bot logged work on GOBBLIN-1648:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 23/May/22 18:34
Start Date: 23/May/22 18:34
Worklog Time Spent: 10m
Work Description: phet commented on code in PR #3509:
URL: https://github.com/apache/gobblin/pull/3509#discussion_r879763417
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/db/ServiceDatabaseProviderImpl.java:
##########
@@ -63,8 +67,10 @@ private synchronized void ensureDataSource() {
dataSource.setUsername(configuration.getUserName());
dataSource.setPassword(configuration.getPassword());
- // MySQL server can timeout a connection so we need to validate
connections.
-
dataSource.setValidationQuery(MysqlDataSourceUtils.QUERY_CONNECTION_IS_VALID_AND_NOT_READONLY);
+ // MySQL server can timeout a connection so need to validate connections
before use
+ final String validationQuery =
MysqlDataSourceUtils.QUERY_CONNECTION_IS_VALID_AND_NOT_READONLY;
+ LOG.info("setting `DataSource` validation query: '" + validationQuery +
"'");
+ dataSource.setValidationQuery(validationQuery);
dataSource.setValidationQueryTimeout(5);
Review Comment:
I don't expect infinite lifetime for the troubleshooter/issues store to be
the cause of the gobblin cluster downtime
Issue Time Tracking
-------------------
Worklog Id: (was: 773646)
Time Spent: 1.5h (was: 1h 20m)
> Avoid Gobblin Cluster Manager downtime during DB failover
> ---------------------------------------------------------
>
> Key: GOBBLIN-1648
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1648
> Project: Apache Gobblin
> Issue Type: Task
> Components: gobblin-cluster
> Reporter: Kip Kohn
> Assignee: Hung Tran
> Priority: Major
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> When the DB fails over (so the currently connected instance which was active
> becomes a follower), the connection on hand becomes read-only. Enforce
> verification when this happens, so we know to create new, replacement
> connections (to a read-write host).
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
