[
https://issues.apache.org/jira/browse/GOBBLIN-1672?focusedWorklogId=797060&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-797060
]
ASF GitHub Bot logged work on GOBBLIN-1672:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 01/Aug/22 23:39
Start Date: 01/Aug/22 23:39
Worklog Time Spent: 10m
Work Description: Will-Lo opened a new pull request, #3532:
URL: https://github.com/apache/gobblin/pull/3532
…executor for SUCCESS, FAILED, SLA_EXCEEDED, START_SLA_EXCEEDED
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I
have checked off all the steps below!
### JIRA
- [x] My PR addresses the following [Gobblin
JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references
them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-1672
### Description
- [x] Here are some details about my PR, including screenshots (if
applicable):
- Add more metrics related to flow management. Since a good chunk of the
code in the DagManager was related to metrics emission, I tried to contain it
within a class.
- Adds the following metrics:
1. Successes per executor
2. Fails per executor
3. SLA Exceeded per executor
4. SLA Exceeded per flowgroup
5. Total SLA Exceeded
6. Jobs sent to spec executors
7. Start SLA exceeded per executor
### Tests
- [x] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
### Commits
- [x] My commits all reference JIRA issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
5. Subject uses the imperative mood ("add", not "adding")
6. Body wraps at 72 characters
7. Body explains "what" and "why", not "how"
Issue Time Tracking
-------------------
Worklog Id: (was: 797060)
Remaining Estimate: 0h
Time Spent: 10m
> Refactor metrics in dagmanager and add per spec executor metrics
> ----------------------------------------------------------------
>
> Key: GOBBLIN-1672
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1672
> Project: Apache Gobblin
> Issue Type: Improvement
> Components: gobblin-service
> Reporter: William Lo
> Assignee: Abhishek Tiwari
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Add the following metrics:
> 1. Success per executor
> 2. Fail per executor
> 3. SLA killed per executor
> 4. SLA killed per flowgroup
> 5. SLA killed per user
> 6. SLA killed overall
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
