AndyJiang99 commented on code in PR #3533:
URL: https://github.com/apache/gobblin/pull/3533#discussion_r940551812
##########
gobblin-runtime/src/main/java/org/apache/gobblin/runtime/spec_store/MysqlSpecStore.java:
##########
@@ -138,7 +139,9 @@ protected SqlStatements createSqlStatements() {
/** Support search, unlike base class (presumably via a {@link
org.apache.gobblin.runtime.api.FlowSpecSearchObject}). */
@Override
public Collection<Spec> getSpecsImpl(SpecSearchObject specSearchObject)
throws IOException {
- return
withPreparedStatement(specSearchObject.augmentBaseGetStatement(this.sqlStatements.getStatementBase),
statement -> {
+ Boolean ifGetAll = ((FlowSpecSearchObject)specSearchObject).getGetAll();
Review Comment:
I think we may need to keep this logic because the GET_STATEMENT_BASE has an
additional WHERE portion in the MySQL statement compared to the
GET_ALL_STATEMENT. If we just use ```this.sqlStatements.getStatementBase```
then the MySQL statement will be incorrect because it has a hanging WHERE
portion
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
