Will-Lo commented on code in PR #3535:
URL: https://github.com/apache/gobblin/pull/3535#discussion_r940691311
##########
gobblin-data-management/src/main/java/org/apache/gobblin/data/management/copy/TimeAwareRecursiveCopyableDataset.java:
##########
@@ -68,7 +68,7 @@ public TimeAwareRecursiveCopyableDataset(FileSystem fs, Path
rootPath, Propertie
this.datePattern = properties.getProperty(DATE_PATTERN_KEY);
this.currentTime = properties.containsKey(DATE_PATTERN_TIMEZONE_KEY) ?
LocalDateTime.now(
- DateTimeZone.forID(DATE_PATTERN_TIMEZONE_KEY))
+ DateTimeZone.forID(properties.getProperty(DATE_PATTERN_TIMEZONE_KEY)))
: LocalDateTime.now(DateTimeZone.forID(DEFAULT_DATE_PATTERN_TIMEZONE));
Review Comment:
I'll follow the UnixTimestampRecursiveCopyableDataset pattern here, thanks
for the heads up :).
For the other 2 maybe we can find a way to aggregate lookback and timezone
configurations across Gobblin jobs so I'll leave them for now. Seems like a
recurring problem in Gobblin where you have 2 configurations with the same
semantics but under different configurations due to being part of different
workflows.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
