[
https://issues.apache.org/jira/browse/GOBBLIN-1677?focusedWorklogId=799128&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-799128
]
ASF GitHub Bot logged work on GOBBLIN-1677:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 08/Aug/22 23:44
Start Date: 08/Aug/22 23:44
Worklog Time Spent: 10m
Work Description: phet commented on code in PR #3535:
URL: https://github.com/apache/gobblin/pull/3535#discussion_r940753420
##########
gobblin-data-management/src/main/java/org/apache/gobblin/data/management/copy/TimeAwareRecursiveCopyableDataset.java:
##########
@@ -68,7 +68,7 @@ public TimeAwareRecursiveCopyableDataset(FileSystem fs, Path
rootPath, Propertie
this.datePattern = properties.getProperty(DATE_PATTERN_KEY);
this.currentTime = properties.containsKey(DATE_PATTERN_TIMEZONE_KEY) ?
LocalDateTime.now(
- DateTimeZone.forID(DATE_PATTERN_TIMEZONE_KEY))
+ DateTimeZone.forID(properties.getProperty(DATE_PATTERN_TIMEZONE_KEY)))
: LocalDateTime.now(DateTimeZone.forID(DEFAULT_DATE_PATTERN_TIMEZONE));
Review Comment:
that's a worthwhile pursuit.... but complicated because our installed/legacy
user base may have come to depend on the old names. in general they can't be
removed... only given an alias. this seems in the spirit of attacking that
proliferation:
https://github.com/apache/gobblin/blob/d9ae5353c74fdcd385835fca9b586b3fdb90971b/gobblin-utility/src/main/java/org/apache/gobblin/util/deprecation/DeprecationUtils.java#L43
but, yes, I agree on the benefit of aligning under a common name for the
'same' concept in use across multiple classes. at this point, I'm don't have
an opinion on which name deserves to 'win' and be enshrined as the 'standard
property name'.
(all that... and... my original suggestion was just to DRY out the code,
eliminating the duplicated calls, not specifically to standardize on a common
property name.)
Issue Time Tracking
-------------------
Worklog Id: (was: 799128)
Time Spent: 1h 20m (was: 1h 10m)
> Fix timezone property in TimeAwareRecursiveCopyableDataset
> ----------------------------------------------------------
>
> Key: GOBBLIN-1677
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1677
> Project: Apache Gobblin
> Issue Type: Bug
> Components: gobblin-core
> Reporter: William Lo
> Assignee: Abhishek Tiwari
> Priority: Major
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> Fix bug where TimeAwareRecursiveCopyableDataset could not read user
> configured timezones due to not reading the key correctly.
> Line 72 : {{DateTimeZone.forID(DATE_PATTERN_TIMEZONE_KEY))}} ===> should be
> {{DateTimeZone.forID(properties.get(DATE_PATTERN_TIMEZONE_KEY)))}}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
