phet commented on code in PR #3543:
URL: https://github.com/apache/gobblin/pull/3543#discussion_r954424593
##########
gobblin-modules/gobblin-orc/src/main/java/org/apache/gobblin/writer/GenericRecordToOrcValueWriter.java:
##########
@@ -344,7 +346,9 @@ public void addValue(int rowId, int column, Object data,
ColumnVector output) {
// make sure the child is big enough
if (cv.childCount > cv.keys.isNull.length) {
int resizedLength = resize(rowsAdded, cv.isNull.length, cv.childCount);
+ log.info("Column vector: {}, resizing to: {}, child count: {}",
cv.keys, resizedLength, cv.childCount);
cv.keys.ensureSize(resizedLength, true);
+ log.info("Column vector: {}, resizing to: {}, child count: {}",
cv.values, resizedLength, cv.childCount);
Review Comment:
just double checking: do the `.keys` and `.values` column vectors have a
meaningful `.toString`... or were you wanting actually to show their
`.isNull.length`?
they likely grow in lockstep, but is it intentional to show the keys before
the potential resize, but show the values after?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
