[
https://issues.apache.org/jira/browse/GOBBLIN-1690?focusedWorklogId=803421&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-803421
]
ASF GitHub Bot logged work on GOBBLIN-1690:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 25/Aug/22 01:35
Start Date: 25/Aug/22 01:35
Worklog Time Spent: 10m
Work Description: phet commented on code in PR #3543:
URL: https://github.com/apache/gobblin/pull/3543#discussion_r954424593
##########
gobblin-modules/gobblin-orc/src/main/java/org/apache/gobblin/writer/GenericRecordToOrcValueWriter.java:
##########
@@ -344,7 +346,9 @@ public void addValue(int rowId, int column, Object data,
ColumnVector output) {
// make sure the child is big enough
if (cv.childCount > cv.keys.isNull.length) {
int resizedLength = resize(rowsAdded, cv.isNull.length, cv.childCount);
+ log.info("Column vector: {}, resizing to: {}, child count: {}",
cv.keys, resizedLength, cv.childCount);
cv.keys.ensureSize(resizedLength, true);
+ log.info("Column vector: {}, resizing to: {}, child count: {}",
cv.values, resizedLength, cv.childCount);
Review Comment:
just double checking: do the `.keys` and `.values` column vectors have a
meaningful `.toString`... or were you wanting actually to show their
`.isNull.length`?
they likely grow in lockstep, but is it intentional to show the keys before
the potential resize, but show the values after?
Issue Time Tracking
-------------------
Worklog Id: (was: 803421)
Time Spent: 20m (was: 10m)
> [Minor] Improve ORC logging in Gobblin ORC Writer
> -------------------------------------------------
>
> Key: GOBBLIN-1690
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1690
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Ratandeep Ratti
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
