Will-Lo commented on code in PR #3542:
URL: https://github.com/apache/gobblin/pull/3542#discussion_r958728174
##########
gobblin-data-management/src/main/java/org/apache/gobblin/data/management/copy/CopySource.java:
##########
@@ -214,6 +214,7 @@ public List<WorkUnit> getWorkunits(final SourceState state)
{
failJobIfAllRequestsRejected(allocator, prioritizedFileSets);
String filesetWuGeneratorAlias =
state.getProp(ConfigurationKeys.COPY_SOURCE_FILESET_WU_GENERATOR_CLASS,
FileSetWorkUnitGenerator.class.getName());
+ boolean isWUFastFailOverEnabled =
state.getPropAsBoolean(ConfigurationKeys.WORK_UNIT_FAST_FAIL_ENABLED, true);
Review Comment:
I also agree that the default of 'true' is justified as well. I'd rather we
not have configuration drift and for a vast majority of use cases having this
enabled is probably the correct behavior, though having a setting to turn this
off is useful in case we missed anything.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
