[
https://issues.apache.org/jira/browse/GOBBLIN-1694?focusedWorklogId=805353&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-805353
]
ASF GitHub Bot logged work on GOBBLIN-1694:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 31/Aug/22 19:10
Start Date: 31/Aug/22 19:10
Worklog Time Spent: 10m
Work Description: jack-moseley opened a new pull request, #3547:
URL: https://github.com/apache/gobblin/pull/3547
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I
have checked off all the steps below!
### JIRA
- [x] My PR addresses the following [Gobblin
JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references
them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-1694
### Description
- [x] Here are some details about my PR, including screenshots (if
applicable):
- Explicitly add the GMCE topic as a field in hive commit events. This was
in the events before from gobblin framework, but in some situations (not sure
why) the event submitter got reset and stopped including it in the events, so
explicitly adding it now. For backwards compatibility keeping the name
`kafkaTopic` for the key.
- Also updated an iceberg writer log line to avoid blowing up the logs when
gmip is going through older offsets (before it printed the entire GMCE which
was extremely large).
### Tests
- [x] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
Tested in gmip test pipeline
### Commits
- [x] My commits all reference JIRA issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
Issue Time Tracking
-------------------
Worklog Id: (was: 805353)
Remaining Estimate: 0h
Time Spent: 10m
> Add GMCE topic explicitly to hive commit event
> ----------------------------------------------
>
> Key: GOBBLIN-1694
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1694
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Jack Moseley
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
