[
https://issues.apache.org/jira/browse/GOBBLIN-1695?focusedWorklogId=807109&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-807109
]
ASF GitHub Bot logged work on GOBBLIN-1695:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 08/Sep/22 16:35
Start Date: 08/Sep/22 16:35
Worklog Time Spent: 10m
Work Description: Will-Lo commented on code in PR #3551:
URL: https://github.com/apache/gobblin/pull/3551#discussion_r966181310
##########
gobblin-modules/gobblin-azkaban/src/main/java/org/apache/gobblin/service/modules/orchestration/AzkabanClient.java:
##########
@@ -130,10 +138,12 @@ private void initializeClient() throws
AzkabanClientException {
private void initializeSessionManager() throws AzkabanClientException {
if (sessionManager == null) {
- this.sessionManager = new AzkabanSessionManager(this.httpClient,
- this.url,
- this.username,
- this.password);
+ try {
+ this.sessionManager = new AzkabanSessionManager(this.httpClient,
this.url, this.username, this.password);
+ }
+ catch(Exception e) {
+ log.error("Failed to initialize session manager due to: ", e);
Review Comment:
I don't see the SessionManager actually throwing anything in the constructor
so the try/catch is redundant
Issue Time Tracking
-------------------
Worklog Id: (was: 807109)
Time Spent: 50m (was: 40m)
> GaaS shouldn't block deployment on adding spec executors
> --------------------------------------------------------
>
> Key: GOBBLIN-1695
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1695
> Project: Apache Gobblin
> Issue Type: Bug
> Reporter: Andy Jiang
> Priority: Major
> Time Spent: 50m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
