umustafi commented on code in PR #3557:
URL: https://github.com/apache/gobblin/pull/3557#discussion_r967405152
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/core/GobblinServiceConfiguration.java:
##########
@@ -70,6 +70,9 @@ public class GobblinServiceConfiguration {
@Getter
private final boolean isHelixManagerEnabled;
+ @Getter
+ private final boolean isSpecStoreChangeMonitorEnabled;
Review Comment:
I was thinking that as well because we do not one turned on without the
other. However neither the `warmStandbyEnabled` or
`specStoreChangeMonitorEnabled` terms encapsulate all the multi-leader mode
changes as a whole. I can create a configuration key `multiLeaderModeEnabled`
which we can use in both places. What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
