Will-Lo commented on code in PR #3558: URL: https://github.com/apache/gobblin/pull/3558#discussion_r969991698
########## gobblin-runtime/src/main/java/org/apache/gobblin/runtime/dag_action_store/MysqlDagActionStore.java: ########## @@ -0,0 +1,172 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.gobblin.runtime.dag_action_store; + +import com.google.inject.Inject; +import com.typesafe.config.Config; +import java.io.IOException; +import java.sql.Connection; +import java.sql.PreparedStatement; +import java.sql.ResultSet; +import java.sql.SQLException; +import java.util.Collection; +import java.util.HashSet; +import javax.sql.DataSource; +import org.apache.gobblin.configuration.ConfigurationKeys; +import org.apache.gobblin.metastore.MysqlStateStore; +import org.apache.gobblin.runtime.api.DagActionStore; +import org.apache.gobblin.util.ConfigUtils; + + +public class MysqlDagActionStore implements DagActionStore { + + public static final String CONFIG_PREFIX = "MysqlDagActionStore"; + + + protected final DataSource dataSource; + private final String tableName; + private static final String EXISTS_STATEMENT = "SELECT EXISTS(SELECT * FROM %s WHERE flow_group = ? AND flow_name =? AND flow_execution_id = ?)"; + + protected static final String INSERT_STATEMENT = "INSERT INTO %s (flow_group, flow_name, flow_execution_id, dag_action ) " + + "VALUES (?, ?, ?, ?)"; + private static final String DELETE_STATEMENT = "DELETE FROM %s WHERE flow_group = ? AND flow_name =? AND flow_execution_id = ?"; + private static final String GET_STATEMENT = "SELECT flow_group, flow_name, flow_execution_id, dag_action FROM %s WHERE flow_group = ? AND flow_name =? AND flow_execution_id = ?"; + private static final String GET_ALL_STATEMENT = "SELECT flow_group, flow_name, flow_execution_id, dag_action FROM %s"; + private static final String CREATE_TABLE_STATEMENT = "CREATE TABLE IF NOT EXISTS %s (" + + "flow_group varchar(128) NOT NULL, flow_name varchar(128) NOT NULL, flow_execution_id varchar(100) NOT NULL," + Review Comment: instead of hardcoding `128` length, can we use our global variables in case this number changes in the future? I see references to `ServiceConfigKeys.MAX_FLOW_GROUP_LENGTH` e.g. ``` private static final String SPECIFIC_CREATE_TABLE_STATEMENT = "CREATE TABLE IF NOT EXISTS %s (spec_uri VARCHAR(" + FlowSpec.Utils.maxFlowSpecUriLength() + ") NOT NULL, flow_group VARCHAR(" + ServiceConfigKeys.MAX_FLOW_GROUP_LENGTH + "), flow_name VARCHAR(" + ServiceConfigKeys.MAX_FLOW_GROUP_LENGTH + ") ``` ########## gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/DagManager.java: ########## @@ -369,6 +387,21 @@ public synchronized void setActive(boolean active) { for (Dag<JobExecutionPlan> dag : dags) { addDag(dag, false, false); } + if (dagActionStore.isPresent()) { + Collection<DagActionStore.DagAction> dagActions = dagActionStore.get().getDagActions(); Review Comment: Do we need to worry about the scenario if we have multiple dagManagers or is that not in scope of this PR? ########## gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/DagManager.java: ########## @@ -296,7 +314,7 @@ synchronized public void stopDag(URI uri) throws IOException { private void killFlow(String flowGroup, String flowName, long flowExecutionId) throws IOException { int queueId = DagManagerUtils.getDagQueueId(flowExecutionId, this.numThreads); String dagId = DagManagerUtils.generateDagId(flowGroup, flowName, flowExecutionId); Review Comment: If we have a dagId static class, it seems to make sense to me that we have a toString() functionality for this and we can remove `DagManagerUtils.generateDagId()` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
