[
https://issues.apache.org/jira/browse/GOBBLIN-1713?focusedWorklogId=811650&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-811650
]
ASF GitHub Bot logged work on GOBBLIN-1713:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 23/Sep/22 16:39
Start Date: 23/Sep/22 16:39
Worklog Time Spent: 10m
Work Description: umustafi commented on code in PR #3567:
URL: https://github.com/apache/gobblin/pull/3567#discussion_r978865161
##########
gobblin-metastore/src/main/java/org/apache/gobblin/metastore/JobHistoryDataSourceProvider.java:
##########
@@ -17,24 +17,42 @@
package org.apache.gobblin.metastore;
+import java.time.Duration;
import java.util.Properties;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
import com.google.inject.Inject;
import com.google.inject.name.Named;
import org.apache.gobblin.configuration.ConfigurationKeys;
import org.apache.gobblin.password.PasswordManager;
+import org.apache.gobblin.util.jdbc.DataSourceProvider;
+import org.apache.gobblin.util.jdbc.MysqlDataSourceUtils;
/**
* This class extends {@link org.apache.gobblin.util.jdbc.DataSourceProvider}
with its own property keys.
*/
public class JobHistoryDataSourceProvider extends
org.apache.gobblin.util.jdbc.DataSourceProvider {
+ private static final Logger LOG =
LoggerFactory.getLogger(DataSourceProvider.class);
Review Comment:
the other classes use logger factory so sticking with that although @sl4j
also works.
Issue Time Tracking
-------------------
Worklog Id: (was: 811650)
Time Spent: 1.5h (was: 1h 20m)
> Add validation check for mysql connection
> ------------------------------------------
>
> Key: GOBBLIN-1713
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1713
> Project: Apache Gobblin
> Issue Type: New Feature
> Reporter: Urmi Mustafi
> Priority: Major
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> Detect once a MySQL connection becomes read-only. Enforce verification when
> this happens, so we know to create new, replacement connections (to a
> read-write host). Adding this check to a code path that was missing this
> check.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
