phet commented on code in PR #3569:
URL: https://github.com/apache/gobblin/pull/3569#discussion_r979112246
##########
gobblin-data-management/src/main/java/org/apache/gobblin/data/management/copy/iceberg/IcebergCatalogFactory.java:
##########
@@ -18,14 +18,19 @@
package org.apache.gobblin.data.management.copy.iceberg;
import org.apache.hadoop.conf.Configuration;
-import org.apache.iceberg.hive.HiveCatalogs;
+import org.apache.iceberg.hive.HiveCatalog;
+
+import com.google.common.collect.Maps;
/**
* Provides an {@link IcebergCatalog}.
*/
public class IcebergCatalogFactory {
public static IcebergCatalog create(Configuration configuration) {
- return new IcebergHiveCatalog(HiveCatalogs.loadCatalog(configuration));
+ HiveCatalog hcat = new HiveCatalog();
Review Comment:
actually `HiveCatalogs` is deprecated and got removed in iceberg 0.12 (we're
on 0.11 currently). I attempted upgrading beyond 0.11 and found that quite
easy (ITO migrating source code). even though we collectively decided to
remain on 0.11, I left this change in, because it's stated to be a drop-in
replacement, and it will be one less thing to do when we're ready for >0.11
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
