[
https://issues.apache.org/jira/browse/GOBBLIN-1703?focusedWorklogId=812668&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-812668
]
ASF GitHub Bot logged work on GOBBLIN-1703:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 27/Sep/22 21:52
Start Date: 27/Sep/22 21:52
Worklog Time Spent: 10m
Work Description: arjun4084346 commented on code in PR #3550:
URL: https://github.com/apache/gobblin/pull/3550#discussion_r981746749
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/MysqlUserQuotaManager.java:
##########
@@ -62,7 +80,7 @@ public void init(Collection<Dag<JobExecutionPlan>> dags) {
@Override
int incrementJobCount(String user, CountType countType) throws IOException {
try {
- return this.mysqlStore.increaseCount(user, countType);
+ return this.quotaStore.increaseCount(user, countType);
Review Comment:
Probably yes, but it was not being done together in InMemory version also.
Do you want me to change both?
Issue Time Tracking
-------------------
Worklog Id: (was: 812668)
Time Spent: 40m (was: 0.5h)
> avoid double quota usage increment for ad hoc flows
> ---------------------------------------------------
>
> Key: GOBBLIN-1703
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1703
> Project: Apache Gobblin
> Issue Type: Bug
> Reporter: Arjun Singh Bora
> Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
> When a gaas flow request comes, resource handler checks the quota right there.
> However, if the flow has runImmediately=true, the quota will be checked again
> when the first job starts. This should be avoided.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
