AndyJiang99 commented on code in PR #3583:
URL: https://github.com/apache/gobblin/pull/3583#discussion_r996166734
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/flowgraph/BaseFlowGraphHelper.java:
##########
@@ -60,21 +60,21 @@
*/
@Slf4j
public class BaseFlowGraphHelper {
- public static final int NODE_FILE_DEPTH = 3;
- public static final int EDGE_FILE_DEPTH = 4;
+ private static final int NODE_FILE_DEPTH = 3;
+ private static final int EDGE_FILE_DEPTH = 4;
Review Comment:
Any reason why these depths were chosen? Could we maybe put this into a
configuration so it can be easily configured if we want to edit these in the
future?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
