[
https://issues.apache.org/jira/browse/GOBBLIN-1724?focusedWorklogId=817184&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-817184
]
ASF GitHub Bot logged work on GOBBLIN-1724:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 14/Oct/22 21:20
Start Date: 14/Oct/22 21:20
Worklog Time Spent: 10m
Work Description: AndyJiang99 commented on code in PR #3583:
URL: https://github.com/apache/gobblin/pull/3583#discussion_r996166734
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/flowgraph/BaseFlowGraphHelper.java:
##########
@@ -60,21 +60,21 @@
*/
@Slf4j
public class BaseFlowGraphHelper {
- public static final int NODE_FILE_DEPTH = 3;
- public static final int EDGE_FILE_DEPTH = 4;
+ private static final int NODE_FILE_DEPTH = 3;
+ private static final int EDGE_FILE_DEPTH = 4;
Review Comment:
Any reason why these depths were chosen? Could we maybe put this into a
configuration so it can be easily configured if we want to edit these in the
future?
Issue Time Tracking
-------------------
Worklog Id: (was: 817184)
Time Spent: 40m (was: 0.5h)
> Support a flowgraph layout for shared node configurations
> ---------------------------------------------------------
>
> Key: GOBBLIN-1724
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1724
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: William Lo
> Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Currently the GaaS Flowgraph assumes that there will be one separate
> flowgraph for each configured use case, but this adds for a large amount of
> duplication when supporting multiple flowgraphs.
> We should support a layout where there can be a directory for shared nodes
> between each flowgraph, and each flowgraph can overwrite properties for these
> nodes if needed.
> e.g.
> {code:java}
> /flowgraph
> ../nodeA
> ..../nodeB
> ......edgeAB.properties
> ../nodeB
> ....nodeB.properties
> /nodes
> ..nodeA.properties
> ..nodeB.properties{code}
> Where nodeA will use the shared properties, and nodeB will use the union of
> the properties in /flowgraph and the shared properties.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
