[
https://issues.apache.org/jira/browse/GOBBLIN-1737?focusedWorklogId=823603&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-823603
]
ASF GitHub Bot logged work on GOBBLIN-1737:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 05/Nov/22 00:04
Start Date: 05/Nov/22 00:04
Worklog Time Spent: 10m
Work Description: ZihanLi58 commented on code in PR #3595:
URL: https://github.com/apache/gobblin/pull/3595#discussion_r1014530369
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/DagManager.java:
##########
@@ -390,7 +390,8 @@ public synchronized void setActive(boolean active) {
this.dagManagerMetrics.activate();
- UserQuotaManager quotaManager = new InMemoryUserQuotaManager(config);
+ UserQuotaManager quotaManager =
GobblinConstructorUtils.invokeConstructor(UserQuotaManager.class,
+ ConfigUtils.getString(config,
ServiceConfigKeys.QUOTA_MANAGER_CLASS,
ServiceConfigKeys.DEFAULT_QUOTA_MANAGER), config);
Review Comment:
In warm standby mode, we need use mysql based quota manager
Issue Time Tracking
-------------------
Worklog Id: (was: 823603)
Time Spent: 40m (was: 0.5h)
> Fix bug when using mysql user quota manager
> -------------------------------------------
>
> Key: GOBBLIN-1737
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1737
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Zihan Li
> Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
> # Change the way we get config to to consistent with other mysql store
> # Only check quota in compiler when the flow compile successful and explain
> flag is not set
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
