meethngala commented on code in PR #3577:
URL: https://github.com/apache/gobblin/pull/3577#discussion_r1017273006
##########
gobblin-data-management/src/test/java/org/apache/gobblin/data/management/copy/iceberg/IcebergDatasetTest.java:
##########
@@ -307,105 +329,137 @@ protected IcebergTable
validateGetFilePathsGivenDestState(
/** @return `paths` after adding to it all paths of every one of
`snapshotDefs` */
protected static Set<Path> withAllSnapshotPaths(Set<Path> paths,
MockIcebergTable.SnapshotPaths... snapshotDefs) {
Arrays.stream(snapshotDefs).flatMap(snapshotDef ->
- snapshotDef.asSnapshotInfo().getAllPaths().stream()
- ).forEach(p ->
- paths.add(new Path(p))
- );
+ snapshotDef.asSnapshotInfo().getAllPaths().stream())
+ .forEach(p ->
+ paths.add(new Path(p))
+ );
return paths;
}
private CopyConfiguration createEmptyCopyConfiguration(FileSystem fs) {
- return CopyConfiguration.builder(fs, copyConfigProperties)
- .copyContext(new CopyContext())
- .build();
+ return CopyConfiguration.builder(fs, copyConfigProperties).copyContext(new
CopyContext()).build();
}
private static void verifyCopyEntities(Collection<CopyEntity> copyEntities,
List<String> expected) {
- List<String> actual = new ArrayList<>();
+ Set<String> actual = new HashSet<>();
Review Comment:
I wanted to leverage `contains` method from HashSet, but I no longer need
it. Have changed it back to List
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@gobblin.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
