[
https://issues.apache.org/jira/browse/GOBBLIN-1739?focusedWorklogId=826299&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-826299
]
ASF GitHub Bot logged work on GOBBLIN-1739:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 15/Nov/22 21:33
Start Date: 15/Nov/22 21:33
Worklog Time Spent: 10m
Work Description: meethngala commented on code in PR #3596:
URL: https://github.com/apache/gobblin/pull/3596#discussion_r1023279051
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/dataset/IcebergDatasetDescriptor.java:
##########
@@ -0,0 +1,86 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.gobblin.service.modules.dataset;
+
+import java.io.IOException;
+import java.util.List;
+
+import com.google.common.base.Joiner;
+import com.google.common.base.Splitter;
+import com.typesafe.config.Config;
+
+import lombok.EqualsAndHashCode;
+import lombok.Getter;
+
+import
org.apache.gobblin.service.modules.flowgraph.DatasetDescriptorConfigKeys;
+import org.apache.gobblin.util.ConfigUtils;
+
+/**
+ * As of now, {@link IcebergDatasetDescriptor} has same implementation as that
of {@link BaseDatasetDescriptor}.
+ * Fields {@link IcebergDatasetDescriptor#databaseName} and {@link
IcebergDatasetDescriptor#tableName} are used to
+ * identify an iceberg. If defined incorrectly, it is set as empty field and
throws {@link IOException}
+ */
+@EqualsAndHashCode(callSuper = true)
+public class IcebergDatasetDescriptor extends BaseDatasetDescriptor {
Review Comment:
updated the PR with changes!
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/flowgraph/datanodes/iceberg/IcebergOnHiveDataNode.java:
##########
@@ -0,0 +1,55 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.gobblin.service.modules.flowgraph.datanodes.iceberg;
+
+import com.typesafe.config.Config;
+
+import lombok.EqualsAndHashCode;
+
+import org.apache.gobblin.annotation.Alpha;
+import org.apache.gobblin.data.management.copy.iceberg.IcebergHiveCatalog;
+import org.apache.gobblin.service.modules.dataset.IcebergDatasetDescriptor;
+import
org.apache.gobblin.service.modules.flowgraph.datanodes.hive.HiveMetastoreUriDataNode;
+
+/**
+ * An {@link IcebergOnHiveDataNode} implementation. In addition to the
required properties of a {@link HiveMetastoreUriDataNode}, an {@link
IcebergOnHiveDataNode}
Review Comment:
updated the PR with changes!
Issue Time Tracking
-------------------
Worklog Id: (was: 826299)
Time Spent: 1.5h (was: 1h 20m)
> Define Datanodes and Dataset Descriptor for Iceberg
> ---------------------------------------------------
>
> Key: GOBBLIN-1739
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1739
> Project: Apache Gobblin
> Issue Type: Task
> Reporter: Meeth Gala
> Priority: Minor
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
