[
https://issues.apache.org/jira/browse/GOBBLIN-1743?focusedWorklogId=827301&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-827301
]
ASF GitHub Bot logged work on GOBBLIN-1743:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 18/Nov/22 23:55
Start Date: 18/Nov/22 23:55
Worklog Time Spent: 10m
Work Description: umustafi commented on code in PR #3602:
URL: https://github.com/apache/gobblin/pull/3602#discussion_r1026981774
##########
gobblin-cluster/src/main/java/org/apache/gobblin/cluster/GobblinTaskRunner.java:
##########
@@ -599,6 +601,7 @@ public void run() {
private Optional<ContainerMetrics> buildContainerMetrics() {
Properties properties = ConfigUtils.configToProperties(this.clusterConfig);
if (GobblinMetrics.isEnabled(properties)) {
+ logger.info("Container metrics are enabled");
Review Comment:
The `METRICS_KAFKA_TOPIC` and other Kafka related metrics parameters in
`ConfigurationKeys` are what we use to define where the `ScheduledReporter`
outputs metrics.
Issue Time Tracking
-------------------
Worklog Id: (was: 827301)
Time Spent: 2h (was: 1h 50m)
> Ensure GobblinTaskRunner works when used without Yarn
> -----------------------------------------------------
>
> Key: GOBBLIN-1743
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1743
> Project: Apache Gobblin
> Issue Type: Bug
> Components: gobblin-core
> Reporter: Urmi Mustafi
> Assignee: Abhishek Tiwari
> Priority: Major
> Time Spent: 2h
> Remaining Estimate: 0h
>
> this PR [https://github.com/apache/gobblin/pull/3519/files] has a call to
> Helix cluster contained outside of a conditional that was previously never
> encountered for Fliptop use case. I moved the call back inside the
> conditional to ensure we don't attempt to retrieve an instanceConfig that is
> not registered with Helix as we don't have Yarn mode enabled.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
