[GitHub] [gobblin] umustafi commented on a diff in pull request #3602: [GOBBLIN-1743] Ensure GobblinTaskRunner works without Yarn use

[GitBox]

umustafi commented on code in PR #3602:
URL: https://github.com/apache/gobblin/pull/3602#discussion_r1026981774


##########
gobblin-cluster/src/main/java/org/apache/gobblin/cluster/GobblinTaskRunner.java:
##########
@@ -599,6 +601,7 @@ public void run() {
   private Optional<ContainerMetrics> buildContainerMetrics() {
     Properties properties = ConfigUtils.configToProperties(this.clusterConfig);
     if (GobblinMetrics.isEnabled(properties)) {
+      logger.info("Container metrics are enabled");

Review Comment:
   The `METRICS_KAFKA_TOPIC` and other Kafka related metrics parameters in 
`ConfigurationKeys` are what we use to define where the `ScheduledReporter` 
outputs metrics. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@gobblin.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org