Will-Lo opened a new pull request, #3612: URL: https://github.com/apache/gobblin/pull/3612
…ime as the FSFlowGraph if their files are updated at the same time as the flowgraph monitor Dear Gobblin maintainers, Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below! ### JIRA - [x] My PR addresses the following [Gobblin JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR" - https://issues.apache.org/jira/browse/GOBBLIN-1752 ### Description - [x] Here are some details about my PR, including screenshots (if applicable): `FSFlowGraphMonitor` and the `ObservingFsFlowTemplateCatalog` have a race condition if they are updated at the same time, the FSFlowGraphMonitor will not reload itself and can be put into a bad state where there are jobs or edges that are incomplete due to deleting the cache mid-update. Instead, we should have `FSFlowGraphMonitor` control the updates to both the flowgraph and the templateCatalog through a configuration `gobblin.service.fsFlowGraphMonitor.monitorTemplateChanges`, which assumes that the templateCatalog is colocated with the flowgraph in the same parent folder. ### Tests - [x] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason: ### Commits - [x] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)": 1. Subject is separated from body by a blank line 2. Subject is limited to 50 characters 3. Subject does not end with a period 4. Subject uses the imperative mood ("add", not "adding") 5. Body wraps at 72 characters 6. Body explains "what" and "why", not "how" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@gobblin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
