homatthew commented on code in PR #3711:
URL: https://github.com/apache/gobblin/pull/3711#discussion_r1244376380
##########
gobblin-cluster/src/main/java/org/apache/gobblin/cluster/GobblinHelixJobLauncher.java:
##########
@@ -462,10 +466,14 @@ public void launchJob(@Nullable JobListener jobListener)
throws JobException {
}
// TODO: Better error handling. The current impl swallows exceptions for
jobs that were started by this method call.
- // One potential way to improve the error handling is to make this error
swallowing conifgurable
+ // One potential way to improve the error handling is to make this error
swallowing configurable
} catch (Throwable t) {
errorInJobLaunching = t;
} finally {
+ if (isCancelWorkflowOnExitEnabled) {
+ cancelJob(jobListener);
Review Comment:
Your approach does work though. If we don't want a flag, and GaaS fliptop
also wants to cancel the workflow on error (I doubt this is the case), then yes
we can do your approach without a flag.
What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
