[
https://issues.apache.org/jira/browse/GOBBLIN-1850?focusedWorklogId=870161&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-870161
]
ASF GitHub Bot logged work on GOBBLIN-1850:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 10/Jul/23 20:20
Start Date: 10/Jul/23 20:20
Worklog Time Spent: 10m
Work Description: AndyJiang99 opened a new pull request, #3714:
URL: https://github.com/apache/gobblin/pull/3714
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I
have checked off all the steps below!
### JIRA
- [ ] My PR addresses the following [Gobblin
JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references
them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-1850
### Description
- [ ] Here are some details about my PR, including screenshots (if
applicable):
Currently, we are dynamically determining at runtime whether to skip
retention on a dataset and we are not allowing hive retention on a view as it
doesn't have access to delete underlying data (#3695).
However, we also need to not allow hive retention on a snapshot as it is
only a point-in-time copy of the filesystem/directory. Instead of failing the
entire job due to this snapshot format, and we do not want to have a static
allow/denylist, it should throw a warning message instead and continue the
retention job onto the next possiblility.
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
Tested with a sample retention job and observed that no exceptions related
to hive snapshot tables were encountered.
### Commits
- [ ] My commits all reference JIRA issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
Issue Time Tracking
-------------------
Worklog Id: (was: 870161)
Remaining Estimate: 0h
Time Spent: 10m
> Skip attempting retention of Snapshot Hive Tables
> -------------------------------------------------
>
> Key: GOBBLIN-1850
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1850
> Project: Apache Gobblin
> Issue Type: Bug
> Reporter: Andy Jiang
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> We should not allow hive retention on a snapshot of the hive table, as it
> doesn't actually have access to the underlying data and instead, is only a
> point-in-time copy of the filesystem and/or directory.
> Instead of throwing on encountering a snapshot of the hive table and failing
> the job (and we are determining at runtime whether to skip a dataset or not
> rather than having a static allowlist/denylist) it's better to throw a
> warning message when snapshot hive tables are encountered.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
