umustafi opened a new pull request, #3715: URL: https://github.com/apache/gobblin/pull/3715
Dear Gobblin maintainers, Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below! ### JIRA - [X] My PR addresses the following [Gobblin JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR" - https://issues.apache.org/jira/browse/GOBBLIN-1851 ### Description - [X] Here are some details about my PR, including screenshots (if applicable): Tests all cases of trying to acquire a lease for a flow action event with one participant involved and makes corresponding fixes in the `MultiActiveLeaseArbiter`. - One key change this PR includes is to remove usage the participant's local `event_timestamp` in the database to identify the particular flow_action event. We swap it out for the database utilize the CURRENT_TIMESTAMP of the database to insert or keep track of our event. This is to avoid any discrepancies between local time and database time for future comparisons. - Large number of fixes relate to MySQL-specific bugs for example NULL values not being permitted by default, syntax errors in creation, inserting into a table with a create statement, etc... ### Tests - [X] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason: Tests the following cases - CASE 1 of acquire lease for a flow action event not present in DB - CASE 2 of acquire lease for a flow action event that already has a valid lease for the same event in db - CASE 3 of trying to acquire a lease for a distinct flow action event, while the previous event's lease is valid - CASE 4 of lease out of date - CASE 5 of no longer leasing the same event in DB - CASE 6 of no longer leasing a distinct event in DB ### Commits - [X] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)": 1. Subject is separated from body by a blank line 2. Subject is limited to 50 characters 3. Subject does not end with a period 4. Subject uses the imperative mood ("add", not "adding") 5. Body wraps at 72 characters 6. Body explains "what" and "why", not "how" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
