[
https://issues.apache.org/jira/browse/GOBBLIN-1855?focusedWorklogId=871662&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-871662
]
ASF GitHub Bot logged work on GOBBLIN-1855:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 18/Jul/23 23:57
Start Date: 18/Jul/23 23:57
Worklog Time Spent: 10m
Work Description: homatthew opened a new pull request, #3718:
URL: https://github.com/apache/gobblin/pull/3718
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I
have checked off all the steps below!
### JIRA
- [X] My PR addresses the following [Gobblin
JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references
them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-XXX
### Description
- [X] Here are some details about my PR, including screenshots (if
applicable):
HiveMetaStoreTest from Iceberg had some minor changes to the class that
affect the order of metastore creation. This did not break our CI because
iceberg tests run as a group in ABC order, so one of the tests was properly
starting the metastore. But going forward, we should call the method and have
an empty catch in case another test already init the hive metastore.
This would cause a NPE when the tests were run in isolation.
### Tests
- [X] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
### Commits
- [ ] My commits all reference JIRA issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
Issue Time Tracking
-------------------
Worklog Id: (was: 871662)
Remaining Estimate: 0h
Time Spent: 10m
> Bug: Metadata writer tests do not work in isolation after upgrading to
> Iceberg 1.2.0
> ------------------------------------------------------------------------------------
>
> Key: GOBBLIN-1855
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1855
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Matthew Ho
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
