Will-Lo opened a new pull request, #3719:
URL: https://github.com/apache/gobblin/pull/3719

   …in cluster system time
   
   Dear Gobblin maintainers,
   
   Please accept this PR. I understand that it will not be reviewed until I 
have checked off all the steps below!
   
   
   ### JIRA
   - [ ] My PR addresses the following [Gobblin 
JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references 
them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
       - https://issues.apache.org/jira/browse/GOBBLIN-1857
   
   ### Description
   - [ ] Here are some details about my PR, including screenshots (if 
applicable):
   Job Execution ID is automatically inferred from the flow execution ID if the 
job was orchestrated by Gobblin-as-a-Service. However, this can lead to bugs in 
conjunction with other job keys such as earlyStop, since it would create 
multiple planningJobs and job IDs sent to Helix. These jobs would then have the 
same execution ID which is rejected by Helix.
   
   When the user sets a configuration 
`gobblin.cluster.job.useGeneratedJobExecutionIds` are set, we want to force the 
Gobblin cluster to default to creating the job execution ID from its timestamp. 
This may make the job harder to track but earlyStop jobs are already difficult 
to track due to having multiple submitted Helix jobs
   
   ### Tests
   - [ ] My PR adds the following unit tests __OR__ does not need testing for 
this extremely good reason:
   Unit tests
   
   ### Commits
   - [ ] My commits all reference JIRA issues in their subject lines, and I 
have squashed multiple commits if they address the same issue. In addition, my 
commits follow the guidelines from "[How to write a good git commit 
message](http://chris.beams.io/posts/git-commit/)":
       1. Subject is separated from body by a blank line
       2. Subject is limited to 50 characters
       3. Subject does not end with a period
       4. Subject uses the imperative mood ("add", not "adding")
       5. Body wraps at 72 characters
       6. Body explains "what" and "why", not "how"
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to