[
https://issues.apache.org/jira/browse/GOBBLIN-1857?focusedWorklogId=871876&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-871876
]
ASF GitHub Bot logged work on GOBBLIN-1857:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 19/Jul/23 20:39
Start Date: 19/Jul/23 20:39
Worklog Time Spent: 10m
Work Description: codecov-commenter commented on PR #3719:
URL: https://github.com/apache/gobblin/pull/3719#issuecomment-1642725029
##
[Codecov](https://app.codecov.io/gh/apache/gobblin/pull/3719?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
Report
> Merging
[#3719](https://app.codecov.io/gh/apache/gobblin/pull/3719?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
(3711276) into
[master](https://app.codecov.io/gh/apache/gobblin/commit/4a9dd53b885f0166dccac5026e4e2c632c98a419?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
(4a9dd53) will **decrease** coverage by `1.98%`.
> The diff coverage is `100.00%`.
```diff
@@ Coverage Diff @@
## master #3719 +/- ##
============================================
- Coverage 46.93% 44.95% -1.98%
+ Complexity 10808 2120 -8688
============================================
Files 2143 412 -1731
Lines 84545 17823 -66722
Branches 9390 2171 -7219
============================================
- Hits 39683 8013 -31670
+ Misses 41244 8950 -32294
+ Partials 3618 860 -2758
```
| [Impacted
Files](https://app.codecov.io/gh/apache/gobblin/pull/3719?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
| Coverage Δ | |
|---|---|---|
|
[...bblin/cluster/GobblinClusterConfigurationKeys.java](https://app.codecov.io/gh/apache/gobblin/pull/3719?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpbkNsdXN0ZXJDb25maWd1cmF0aW9uS2V5cy5qYXZh)
| `50.00% <ø> (ø)` | |
|
[...a/org/apache/gobblin/cluster/HelixJobsMapping.java](https://app.codecov.io/gh/apache/gobblin/pull/3719?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvSGVsaXhKb2JzTWFwcGluZy5qYXZh)
| `81.53% <100.00%> (+0.58%)` | :arrow_up: |
... and [1733 files with indirect coverage
changes](https://app.codecov.io/gh/apache/gobblin/pull/3719/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD
build times. [Learn
more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
Issue Time Tracking
-------------------
Worklog Id: (was: 871876)
Time Spent: 20m (was: 10m)
> Allow override key for job execution ID in Helix Gobblin Cluster
> ----------------------------------------------------------------
>
> Key: GOBBLIN-1857
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1857
> Project: Apache Gobblin
> Issue Type: Bug
> Components: gobblin-cluster
> Reporter: William Lo
> Assignee: Hung Tran
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Job Execution ID is automatically inferred from the flow execution ID if the
> job was orchestrated by Gobblin-as-a-Service. However, this can lead to bugs
> in conjunction with other job keys such as earlyStop, since it would create
> multiple planningJobs and job IDs sent to Helix. These jobs would then have
> the same execution ID which is rejected by Helix.
> When those configurations are set, we want to force the Gobblin cluster to
> default to creating the job execution ID from its timestamp.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
