[
https://issues.apache.org/jira/browse/GOBBLIN-1859?focusedWorklogId=872260&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-872260
]
ASF GitHub Bot logged work on GOBBLIN-1859:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 21/Jul/23 22:08
Start Date: 21/Jul/23 22:08
Worklog Time Spent: 10m
Work Description: umustafi opened a new pull request, #3721:
URL: https://github.com/apache/gobblin/pull/3721
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I
have checked off all the steps below!
### JIRA
- [X] My PR addresses the following [Gobblin
JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references
them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-1859
### Description
- [X] Here are some details about my PR, including screenshots (if
applicable):
In multi-active mode, multiple participants will be reading/writing to MySQL
table. We want to make sure each participant acts on the table in a manner that
takes into account that the state may have changed while the
MultiActiveLeaseArbiter is processing the result of a READ. This PR adds unit
tests that validate SQL Insertion statements are conditional upon the state of
the particular row corresponding to the flow action event being unchanged from
the read made by this participant.
### Tests
- [X] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
The PR adds 3 unit tests to test each of the cases of acquiring a lease to
ensure the following insertions do not complete if the state has changed from
our initial read.
- insert when there is no matching primary key in the table
- insert if a lease has expired
- insert if a lease has completed
### Commits
- [X] My commits all reference JIRA issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
Issue Time Tracking
-------------------
Worklog Id: (was: 872260)
Remaining Estimate: 0h
Time Spent: 10m
> Multi-active Unit Test for Multiple Participant
> -----------------------------------------------
>
> Key: GOBBLIN-1859
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1859
> Project: Apache Gobblin
> Issue Type: Bug
> Components: gobblin-service
> Reporter: Urmi Mustafi
> Assignee: Abhishek Tiwari
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> In multi-active mode, multiple participants will be reading/writing to MySQL
> table. We want to make sure each participant acts on the table in a manner
> that takes into account that the state may have changed while the
> MultiActiveLeaseArbiter is processing the result of a READ. This PR adds unit
> tests that validate SQL Insertion statements are conditional upon the state
> of the particular row corresponding to the flow action event being unchanged
> from the read made by this participant.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
