[
https://issues.apache.org/jira/browse/GOBBLIN-1863?focusedWorklogId=873901&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-873901
]
ASF GitHub Bot logged work on GOBBLIN-1863:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 31/Jul/23 21:10
Start Date: 31/Jul/23 21:10
Worklog Time Spent: 10m
Work Description: phet commented on code in PR #3727:
URL: https://github.com/apache/gobblin/pull/3727#discussion_r1279648102
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/Orchestrator.java:
##########
@@ -374,9 +358,41 @@ public void orchestrate(Spec spec, Properties jobProps,
long triggerTimestampMil
Instrumented.updateTimer(this.flowOrchestrationTimer, System.nanoTime() -
startTime, TimeUnit.NANOSECONDS);
}
+ /**
+ * Abstraction used to populate the message of and emit a FlowCompileFailed
event for the Orchestrator.
+ * @param spec
+ * @param flowMetadata
+ */
+ public void emitFlowCompilationFailedEvent(Spec spec, Map<String, String>
flowMetadata) {
Review Comment:
no biggie, but naming-wise, I agree the timing is emitted... but what may be
most noteworthy is that it inserts the `METADATA_MESSAGE`
Issue Time Tracking
-------------------
Worklog Id: (was: 873901)
Time Spent: 1h 10m (was: 1h)
> Multi-Active Launch Job Related Issues
> --------------------------------------
>
> Key: GOBBLIN-1863
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1863
> Project: Apache Gobblin
> Issue Type: Bug
> Reporter: Urmi Mustafi
> Priority: Major
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> * DagManager check leader status before addDag bc calling this method from
> non-leader hosts throws a NPE which may caused failed dag event to be emitted
> * also handle LAUNCH type events upon leader change and setting a new
> participant DagManager to be active. Failing to handle these events may be
> causing missed flow launches on any leader change or restart.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
