[
https://issues.apache.org/jira/browse/GOBBLIN-1862?focusedWorklogId=873914&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-873914
]
ASF GitHub Bot logged work on GOBBLIN-1862:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 31/Jul/23 22:48
Start Date: 31/Jul/23 22:48
Worklog Time Spent: 10m
Work Description: codecov-commenter commented on PR #3725:
URL: https://github.com/apache/gobblin/pull/3725#issuecomment-1659293895
##
[Codecov](https://app.codecov.io/gh/apache/gobblin/pull/3725?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
Report
> Merging
[#3725](https://app.codecov.io/gh/apache/gobblin/pull/3725?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
(a157e53) into
[master](https://app.codecov.io/gh/apache/gobblin/commit/ba408f23c89357bc36ee70415041c2cff2b36df0?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
(ba408f2) will **increase** coverage by `3.89%`.
> Report is 2 commits behind head on master.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #3725 +/- ##
============================================
+ Coverage 46.26% 50.15% +3.89%
+ Complexity 7306 5833 -1473
============================================
Files 1452 1070 -382
Lines 56625 41015 -15610
Branches 6129 4596 -1533
============================================
- Hits 26195 20572 -5623
+ Misses 28190 18655 -9535
+ Partials 2240 1788 -452
```
[see 383 files with indirect coverage
changes](https://app.codecov.io/gh/apache/gobblin/pull/3725/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD
build times. [Learn
more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
Issue Time Tracking
-------------------
Worklog Id: (was: 873914)
Time Spent: 0.5h (was: 20m)
> Allow reference count to be 0 but no less
> -----------------------------------------
>
> Key: GOBBLIN-1862
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1862
> Project: Apache Gobblin
> Issue Type: Bug
> Reporter: Andy Jiang
> Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Due to possible issues upstream reporting incorrect reference counts for
> number of records, there could be times when the reference count reported to
> be 0.
> In the current case, if reference tier counter is reported to be 0, an
> exception is thrown, however is silently swallowed. Thus, causing the
> watermark to not move forward in this case or in the case of a quiet topic
> for hours where there are no records.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
