ZihanLi58 commented on code in PR #3725:
URL: https://github.com/apache/gobblin/pull/3725#discussion_r1279923416
##########
gobblin-completeness/src/main/java/org/apache/gobblin/completeness/verifier/KafkaAuditCountVerifier.java:
##########
@@ -217,8 +217,10 @@ private static void validateTierCounts(String datasetName,
long beginInMillis, l
throw new IOException(String.format("Reference tier %s audit count
cannot be retrieved for dataset %s between %s and %s", refTier, datasetName,
beginInMillis, endInMillis));
}
long refCount = countsByTier.get(refTier);
- if(refCount <= 0) {
- throw new IOException(String.format("Reference tier %s count cannot be
less than or equal to zero", refTier));
+ if (refCount == 0) {
Review Comment:
Oh I saw it in the PR description, can you also add that as one comment in
the code saying if refTier is 0, we will always think data for that hour is
completed?
##########
gobblin-completeness/src/main/java/org/apache/gobblin/completeness/verifier/KafkaAuditCountVerifier.java:
##########
@@ -217,8 +217,10 @@ private static void validateTierCounts(String datasetName,
long beginInMillis, l
throw new IOException(String.format("Reference tier %s audit count
cannot be retrieved for dataset %s between %s and %s", refTier, datasetName,
beginInMillis, endInMillis));
}
long refCount = countsByTier.get(refTier);
- if(refCount <= 0) {
- throw new IOException(String.format("Reference tier %s count cannot be
less than or equal to zero", refTier));
+ if (refCount == 0) {
Review Comment:
what will happen if the src tier is not 0 but ref tier is 0?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
