[
https://issues.apache.org/jira/browse/GOBBLIN-1884?focusedWorklogId=877114&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-877114
]
ASF GitHub Bot logged work on GOBBLIN-1884:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 19/Aug/23 02:15
Start Date: 19/Aug/23 02:15
Worklog Time Spent: 10m
Work Description: phet commented on code in PR #3746:
URL: https://github.com/apache/gobblin/pull/3746#discussion_r1298832738
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/DagManager.java:
##########
@@ -504,12 +505,15 @@ public void
handleLaunchFlowEvent(DagActionStore.DagAction action) {
if (optionalJobExecutionPlanDag.isPresent()) {
addDag(optionalJobExecutionPlanDag.get(), true, true);
}
+ // Upon handling the action, delete it so on leadership change this is
not duplicated
+ this.dagActionStore.get().deleteDagAction(action);
Review Comment:
I wouldn't expect more than the *highly infrequent* failure between `addDag`
and execution of that very next line. and even then wouldn't it be at most one
DAG getting duplicated per service restart (so VERY SLOW growth)?
Issue Time Tracking
-------------------
Worklog Id: (was: 877114)
Remaining Estimate: 0h
Time Spent: 10m
> Delete launch dag actions after handling them
> ---------------------------------------------
>
> Key: GOBBLIN-1884
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1884
> Project: Apache Gobblin
> Issue Type: Bug
> Components: gobblin-service
> Reporter: Urmi Mustafi
> Assignee: Abhishek Tiwari
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> There is a bug in which launch actions get accumulated and "stuck" in the dag
> action store, so every time a leader is changed or the service is re-deployed
> we will keep redoing old launch actions again and again.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
