[
https://issues.apache.org/jira/browse/GOBBLIN-1887?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Urmi Mustafi updated GOBBLIN-1887:
----------------------------------
Description:
Increase abstraction and encapsulation in FlowTriggerHandler with minor
refactoring to static helper functions. Unpack objects as late as possible to
make {{scheduleReminderForEvent}} easier to read. Add unit tests for each of
the static helper functions.
Increase abstraction and encapsulation in {{FlowTriggerHandler}} with minor
refactoring to static helper functions. Unpack objects as late as possible to
make `scheduleReminderForEvent` easier to read. Add unit tests for each of the
static helper functions.
Bug fix 1: Ensure that the `reminderJobKey` is also used as the
`reminderTrigger's` key
Bug fix 2: Utilize the `jobProps` to determine `triggerEventTimeMillis` for
reminder events
was:Increase abstraction and encapsulation in FlowTriggerHandler with minor
refactoring to static helper functions. Unpack objects as late as possible to
make {{scheduleReminderForEvent}} easier to read. Add unit tests for each of
the static helper functions. Also ensure that the {{reminderJobKey}} is also
used as the {{reminderTrigger's key}}
> Increase Encapsulation in FlowTriggerHandler & Add Unit Tests
> -------------------------------------------------------------
>
> Key: GOBBLIN-1887
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1887
> Project: Apache Gobblin
> Issue Type: Bug
> Components: gobblin-service
> Reporter: Urmi Mustafi
> Assignee: Abhishek Tiwari
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Increase abstraction and encapsulation in FlowTriggerHandler with minor
> refactoring to static helper functions. Unpack objects as late as possible to
> make {{scheduleReminderForEvent}} easier to read. Add unit tests for each of
> the static helper functions.
> Increase abstraction and encapsulation in {{FlowTriggerHandler}} with minor
> refactoring to static helper functions. Unpack objects as late as possible to
> make `scheduleReminderForEvent` easier to read. Add unit tests for each of
> the static helper functions.
> Bug fix 1: Ensure that the `reminderJobKey` is also used as the
> `reminderTrigger's` key
> Bug fix 2: Utilize the `jobProps` to determine `triggerEventTimeMillis` for
> reminder events
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
