[
https://issues.apache.org/jira/browse/GOBBLIN-1887?focusedWorklogId=878693&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-878693
]
ASF GitHub Bot logged work on GOBBLIN-1887:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 28/Aug/23 17:57
Start Date: 28/Aug/23 17:57
Worklog Time Spent: 10m
Work Description: Will-Lo merged PR #3749:
URL: https://github.com/apache/gobblin/pull/3749
Issue Time Tracking
-------------------
Worklog Id: (was: 878693)
Time Spent: 1h 20m (was: 1h 10m)
> Increase Encapsulation in FlowTriggerHandler & Handle Reminder Events Properly
> ------------------------------------------------------------------------------
>
> Key: GOBBLIN-1887
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1887
> Project: Apache Gobblin
> Issue Type: Bug
> Components: gobblin-service
> Reporter: Urmi Mustafi
> Assignee: Abhishek Tiwari
> Priority: Major
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> Increase abstraction and encapsulation in {{FlowTriggerHandler}} with minor
> refactoring to static helper functions. Unpack objects as late as possible to
> make {{scheduleReminderForEvent}} easier to read. Add unit tests for each of
> the static helper functions.
> Bug fix 1: Ensure that the {{reminderJobKey}} is also used as the
> {{reminderTrigger's}} key
> Bug fix 2: Utilize the {{jobProps}} to determine {{triggerEventTimeMillis}}
> for reminder events
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
