Will-Lo commented on code in PR #3751:
URL: https://github.com/apache/gobblin/pull/3751#discussion_r1307850149
##########
gobblin-modules/gobblin-orc/src/main/java/org/apache/gobblin/writer/GobblinBaseOrcWriter.java:
##########
@@ -44,21 +47,47 @@ public abstract class GobblinBaseOrcWriter<S, D> extends
FsDataWriter<D> {
public static final String ORC_WRITER_PREFIX = "orcWriter.";
public static final String ORC_WRITER_BATCH_SIZE = ORC_WRITER_PREFIX +
"batchSize";
public static final int DEFAULT_ORC_WRITER_BATCH_SIZE = 1000;
+ public static final String ORC_WRITER_AUTO_SELFTUNE_ENABLED =
ORC_WRITER_PREFIX + "auto.selfTune.enabled";
+ public static final String ORC_WRITER_ESTIMATED_RECORD_SIZE =
ORC_WRITER_PREFIX + "estimated.recordSize";
+ public static final String ORC_WRITER_AUTO_SELFTUNE_FREQUENCY =
ORC_WRITER_PREFIX + "auto.selfTune.frequency";
+ public static final int DEFAULT_ORC_AUTO_SELFTUNE_FREQUENCY = 500;
+ public static final String
ORC_WRITER_ESTIMATED_BYTES_ALLOCATED_CONVERTER_MEMORY = ORC_WRITER_PREFIX +
"estimated.bytes.allocated.converter.memory";
+ private static final int MAX_CONCURRENT_WRITERS_CONTAINER = 3;
Review Comment:
Yup added a comment and made 3 a conservative default, now it is reading the
value from PartitionedDataWriters to get the concurrency
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
