phet commented on code in PR #3768:
URL: https://github.com/apache/gobblin/pull/3768#discussion_r1323924378
##########
gobblin-salesforce/src/main/java/org/apache/gobblin/salesforce/SalesforceSource.java:
##########
@@ -155,19 +133,25 @@ protected void addLineageSourceInfo(SourceState
sourceState, SourceEntity entity
}
@Override
protected List<WorkUnit> generateWorkUnits(SourceEntity sourceEntity,
SourceState state, long previousWatermark) {
- List<WorkUnit> workUnits = null;
- workUnitConf = new SfConfig(state.getProperties());
+ SalesforceConnector connector = getConnector(state);
Review Comment:
if used only to initialize the histogram service, scope it to within that
(`== null`) path of the conditional
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
