[
https://issues.apache.org/jira/browse/GOBBLIN-1907?focusedWorklogId=880270&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-880270
]
ASF GitHub Bot logged work on GOBBLIN-1907:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 13/Sep/23 22:32
Start Date: 13/Sep/23 22:32
Worklog Time Spent: 10m
Work Description: phet commented on code in PR #3771:
URL: https://github.com/apache/gobblin/pull/3771#discussion_r1325136912
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/scheduler/GobblinServiceJobScheduler.java:
##########
@@ -496,7 +496,9 @@ public void runJob(Properties jobProps, JobListener
jobListener) throws JobExcep
ConfigurationKeys.ORCHESTRATOR_TRIGGER_EVENT_TIME_NEVER_SET_VAL);
this.orchestrator.orchestrate(flowSpec, jobProps,
Long.parseLong(triggerTimestampMillis));
} catch (Exception e) {
- throw new JobException("Failed to run Spec: " +
jobProps.getProperty(ConfigurationKeys.JOB_NAME_KEY), e);
+ String exceptionPrefix = "Failed to run Spec: " +
jobProps.getProperty(ConfigurationKeys.JOB_NAME_KEY);
+ log.warn(exceptionPrefix + " with stacktrace", e);
Review Comment:
nit: "with stacktrace" is fine, but "because" might read better
##########
gobblin-runtime/src/main/java/org/apache/gobblin/runtime/api/MysqlMultiActiveLeaseArbiter.java:
##########
@@ -544,6 +553,7 @@ static class GetEventInfoResult {
*/
@Data
static class SelectInfoResult {
+ public static final long LEASE_COMPLETED_VALUE = -1;
Review Comment:
how about an `Optional` instead?
##########
gobblin-runtime/src/test/java/org/apache/gobblin/runtime/api/MysqlMultiActiveLeaseArbiterTest.java:
##########
@@ -17,8 +17,10 @@
package org.apache.gobblin.runtime.api;
+import com.google.common.base.Optional;
Review Comment:
let's use java `Optional`
(seems the original class under test mistakenly used the deprecated guava
one... I presume it's not too difficult at this early stage to correct)
Issue Time Tracking
-------------------
Worklog Id: (was: 880270)
Time Spent: 20m (was: 10m)
> Handle Lease Completion From Other Participants MA Scheduler
> ------------------------------------------------------------
>
> Key: GOBBLIN-1907
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1907
> Project: Apache Gobblin
> Issue Type: New Feature
> Components: gobblin-service
> Reporter: Urmi Mustafi
> Assignee: Abhishek Tiwari
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> When other participants complete a lease (not just acquire it) in the time
> that the current participant has attempted the lease, we will see a NULL
> lease_acquisition_timestamp and should appropriately handle the resulting
> value. This case was missed and we were only expecting another participant to
> have acquired the lease.
> We also add warning logs for JobExceptions that can be hiding the stack trace
> of errors encountered in runtime.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
