[
https://issues.apache.org/jira/browse/GOBBLIN-1908?focusedWorklogId=880451&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-880451
]
ASF GitHub Bot logged work on GOBBLIN-1908:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 14/Sep/23 15:42
Start Date: 14/Sep/23 15:42
Worklog Time Spent: 10m
Work Description: phet commented on code in PR #3772:
URL: https://github.com/apache/gobblin/pull/3772#discussion_r1326148140
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/scheduler/GobblinServiceJobScheduler.java:
##########
@@ -466,8 +466,9 @@ public synchronized void scheduleJob(Properties jobProps,
JobListener jobListene
@Override
protected void logNewlyScheduledJob(JobDetail job, Trigger trigger) {
Properties jobProps = (Properties) job.getJobDataMap().get(PROPERTIES_KEY);
- log.info(jobSchedulerTracePrefixBuilder(jobProps) + "nextTriggerTime: {} -
Job newly scheduled",
- asUTCEpochMillis(trigger.getNextFireTime()));
+ log.info(jobSchedulerTracePrefixBuilder(jobProps) + "nextTriggerTime: {}
localConversionTriggerTime:{} - Job newly "
Review Comment:
shouldn't this be named localConversion*Next*TriggerTime ?
nit: rather than the prefix "local conversion", which suggests how we
calculate it, I'd opt instead for "localTZ" or "localZoned", which names what
it is
Issue Time Tracking
-------------------
Worklog Id: (was: 880451)
Time Spent: 20m (was: 10m)
> Fix Date to Milliseconds Conversion to Use UTC
> -----------------------------------------------
>
> Key: GOBBLIN-1908
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1908
> Project: Apache Gobblin
> Issue Type: New Feature
> Components: gobblin-service
> Reporter: Urmi Mustafi
> Assignee: Abhishek Tiwari
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> We had previously assumed the Date object returned from a Trigger uses the
> system default timezone, but taking a look at the javadoc and runtime values
> have shown it is already in UTC so we update our conversion function. To
> prevent further confusion about timezones, we also log the conversion that
> assumes the Date object is in system default timezone to make it easier to
> debug.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
