phet commented on code in PR #3778: URL: https://github.com/apache/gobblin/pull/3778#discussion_r1329630091
########## gobblin-cluster/src/main/java/org/apache/gobblin/cluster/temporal/AbstractNestingExecWorkflowImpl.java: ########## Review Comment: this and a bunch of other files represent cumulatively a specific worker w/ its particular workflows and activities (plus supporting abstractions, like `Workload` and `WFAddr`)--let's put them into their own package, separate from the worker-agnostic scaffolding for running arbitrary workers. I know we presently hard-code this one, but our next follow-on PR will be to load whatever configured specific worker using reflection. separating today's "example worker" from the reusable scaffolding, anticipates that future. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
