[
https://issues.apache.org/jira/browse/GOBBLIN-1914?focusedWorklogId=881061&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-881061
]
ASF GitHub Bot logged work on GOBBLIN-1914:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 21/Sep/23 01:33
Start Date: 21/Sep/23 01:33
Worklog Time Spent: 10m
Work Description: phet commented on code in PR #3781:
URL: https://github.com/apache/gobblin/pull/3781#discussion_r1332342465
##########
gobblin-yarn/src/main/java/org/apache/gobblin/yarn/GobblinYarnConfigurationKeys.java:
##########
@@ -30,6 +30,9 @@ public class GobblinYarnConfigurationKeys {
public static final String GOBBLIN_YARN_PREFIX = "gobblin.yarn.";
// General Gobblin Yarn application configuration properties.
+ public static final String APP_MASTER_CLASS = GOBBLIN_YARN_PREFIX +
"app.master.class";
+ public static final String DEFAULT_APP_MASTER_CLASS =
GobblinApplicationMaster.class.getName();
Review Comment:
these are in the same package, so potentially OK... but just noting this
introduces a circular dependency between the two classes
Issue Time Tracking
-------------------
Worklog Id: (was: 881061)
Time Spent: 1h 40m (was: 1.5h)
> Add ability to determine App master class from runtime config
> -------------------------------------------------------------
>
> Key: GOBBLIN-1914
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1914
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Matthew Ho
> Priority: Major
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
