[
https://issues.apache.org/jira/browse/GOBBLIN-1910?focusedWorklogId=881076&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-881076
]
ASF GitHub Bot logged work on GOBBLIN-1910:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 21/Sep/23 06:04
Start Date: 21/Sep/23 06:04
Worklog Time Spent: 10m
Work Description: phet commented on code in PR #3776:
URL: https://github.com/apache/gobblin/pull/3776#discussion_r1332487428
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/task/KillDagTask.java:
##########
@@ -0,0 +1,51 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.gobblin.service.modules.orchestration.task;
+
+import lombok.Getter;
+
+import org.apache.gobblin.annotation.Alpha;
+import org.apache.gobblin.runtime.api.DagActionStore;
+import org.apache.gobblin.runtime.api.MultiActiveLeaseArbiter;
+import org.apache.gobblin.service.modules.orchestration.DagManager;
+import org.apache.gobblin.service.modules.orchestration.DagManagerUtils;
+import org.apache.gobblin.service.modules.orchestration.DagTaskVisitor;
+
+
+/**
+ * A {@link DagTask} responsible to handle kill tasks.
+ */
+@Alpha
+public class KillDagTask extends DagTask {
+
+ @Getter
+ private final DagManager.DagId killDagId;
+ protected final DagActionStore.DagAction killAction;
+
+ public KillDagTask(DagActionStore.DagAction killAction,
MultiActiveLeaseArbiter.LeaseObtainedStatus leaseObtainedStatus) {
+
+ this.killAction = killAction;
+ this.leaseObtainedStatusStatus = leaseObtainedStatus;
+ this.killDagId = DagManagerUtils.generateDagId(killAction.getFlowGroup(),
killAction.getFlowName(), killAction.getFlowExecutionId());
+ }
+
+ @Override
+ public Object host(DagTaskVisitor visitor) throws Exception {
Review Comment:
shouldn't the signature be:
```
public DagProc host(DagTaskVisitor<DagProc> visitor);
```
?
also, what is the exception you think the `DagTaskVisitor.meet` method might
throw?
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/task/KillDagTask.java:
##########
@@ -0,0 +1,51 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.gobblin.service.modules.orchestration.task;
+
+import lombok.Getter;
+
+import org.apache.gobblin.annotation.Alpha;
+import org.apache.gobblin.runtime.api.DagActionStore;
+import org.apache.gobblin.runtime.api.MultiActiveLeaseArbiter;
+import org.apache.gobblin.service.modules.orchestration.DagManager;
+import org.apache.gobblin.service.modules.orchestration.DagManagerUtils;
+import org.apache.gobblin.service.modules.orchestration.DagTaskVisitor;
+
+
+/**
+ * A {@link DagTask} responsible to handle kill tasks.
+ */
+@Alpha
+public class KillDagTask extends DagTask {
+
+ @Getter
+ private final DagManager.DagId killDagId;
+ protected final DagActionStore.DagAction killAction;
+
+ public KillDagTask(DagActionStore.DagAction killAction,
MultiActiveLeaseArbiter.LeaseObtainedStatus leaseObtainedStatus) {
+
+ this.killAction = killAction;
+ this.leaseObtainedStatusStatus = leaseObtainedStatus;
+ this.killDagId = DagManagerUtils.generateDagId(killAction.getFlowGroup(),
killAction.getFlowName(), killAction.getFlowExecutionId());
+ }
+
+ @Override
+ public Object host(DagTaskVisitor visitor) throws Exception {
Review Comment:
shouldn't the signature be:
```
public DagProc host(DagTaskVisitor<DagProc> visitor);
```
?
also, what is the `Exception` you think the `DagTaskVisitor.meet` method
might throw?
Issue Time Tracking
-------------------
Worklog Id: (was: 881076)
Time Spent: 5h 50m (was: 5h 40m)
> Refactor code to move current in-memory references to new design for REST
> calls: Launch, Resume and Kill
> --------------------------------------------------------------------------------------------------------
>
> Key: GOBBLIN-1910
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1910
> Project: Apache Gobblin
> Issue Type: New Feature
> Reporter: Meeth Gala
> Priority: Major
> Time Spent: 5h 50m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
