Will-Lo commented on code in PR #3786:
URL: https://github.com/apache/gobblin/pull/3786#discussion_r1333398355
##########
gobblin-cluster/src/main/java/org/apache/gobblin/cluster/GobblinHelixJobTask.java:
##########
@@ -211,14 +211,15 @@ public TaskResult run() {
try {
this.jobsMapping.deleteMapping(jobUri);
} catch (Exception e) {
+ log.warn("Failed to delete jobs mapping for job: {}", jobUri, e);
return new TaskResult(TaskResult.Status.FAILED,"Cannot delete jobs
mapping for job : " + jobUri);
}
}
}
@Override
public void cancel() {
- log.info("Cancelling planning job {}", this.planningJobId);
+ log.info("Cancelling planning job {} | jobTaskMetrics: {}",
this.planningJobId, this.jobTaskMetrics);
Review Comment:
If you're logging the metrics like this it would just print a reference to
the java object? Is that intended?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
