phet commented on code in PR #3790:
URL: https://github.com/apache/gobblin/pull/3790#discussion_r1343044330
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/FlowTriggerHandler.java:
##########
@@ -278,6 +280,8 @@ public static JobDataMap updatePropsInJobDataMap(JobDataMap
jobDataMap,
// excess flows to be triggered by the reminder functionality.
prevJobProps.setProperty(ConfigurationKeys.SCHEDULER_PRESERVED_CONSENSUS_EVENT_TIME_MILLIS_KEY,
String.valueOf(leasedToAnotherStatus.getEventTimeMillis()));
+ // Use this boolean to indicate whether this is a reminder event
+ prevJobProps.setProperty(ConfigurationKeys.FLOW_IS_REMINDER_EVENT_KEY,
String.valueOf(true));
Review Comment:
please document in comment why defaulting to `true` is preferable. In
isolation, I'd naively imagine `false` to be what we want, but if the dynamic
code path to get here tells us to presume `true`, just highlight the reasoning
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
