phet commented on code in PR #3776: URL: https://github.com/apache/gobblin/pull/3776#discussion_r1343372682
########## gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/DagTaskStream.java: ########## @@ -0,0 +1,255 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.gobblin.service.modules.orchestration; + +import java.io.IOException; +import java.util.Iterator; +import java.util.Properties; +import java.util.concurrent.BlockingQueue; +import java.util.concurrent.ExecutionException; +import java.util.concurrent.LinkedBlockingQueue; + +import org.jetbrains.annotations.NotNull; + +import com.typesafe.config.Config; +import com.typesafe.config.ConfigException; + +import lombok.AllArgsConstructor; +import lombok.Getter; +import lombok.extern.slf4j.Slf4j; + +import org.apache.gobblin.annotation.Alpha; +import org.apache.gobblin.configuration.ConfigurationKeys; +import org.apache.gobblin.metrics.event.TimingEvent; +import org.apache.gobblin.runtime.api.DagActionStore; +import org.apache.gobblin.runtime.api.MultiActiveLeaseArbiter; +import org.apache.gobblin.service.ExecutionStatus; +import org.apache.gobblin.service.modules.flowgraph.Dag; +import org.apache.gobblin.service.modules.orchestration.proc.KillDagProc; +import org.apache.gobblin.service.modules.orchestration.task.DagTask; +import org.apache.gobblin.service.modules.orchestration.task.KillDagTask; +import org.apache.gobblin.service.modules.spec.JobExecutionPlan; +import org.apache.gobblin.service.monitoring.JobStatus; +import org.apache.gobblin.service.monitoring.JobStatusRetriever; + +import static org.apache.gobblin.service.ExecutionStatus.ORCHESTRATED; +import static org.apache.gobblin.service.ExecutionStatus.valueOf; + + +/** + * Holds a stream of {@link DagTask} that {@link DagProcessingEngine} would pull from to process, as it is ready for more work. + * It provides an implementation for {@link DagManagement} that defines the rules for a flow and job. + * Implements {@link Iterable} to provide {@link DagTask}s as soon as it's available to {@link DagProcessingEngine} + */ + +@Alpha +@Slf4j +@AllArgsConstructor +public class DagTaskStream implements Iterable<DagTask>, DagManagement { + + @Getter + private final BlockingQueue<DagActionStore.DagAction> dagActionQueue = new LinkedBlockingQueue<>(); + private FlowTriggerHandler flowTriggerHandler; + private DagManagementStateStore dagManagementStateStore; + private DagManagerMetrics dagManagerMetrics; + + + @NotNull + @Override + public Iterator<DagTask> iterator() { + return new Iterator<DagTask>() { + + @Override + public boolean hasNext() { + return true; + } + + @Override + public DagTask next() { + + DagTask dagTask = null; + while(true) { + DagActionStore.DagAction dagAction = take(); + Properties jobProps = getJobProperties(dagAction); + try { + MultiActiveLeaseArbiter.LeaseAttemptStatus leaseAttemptStatus = flowTriggerHandler.getLeaseOnDagAction(jobProps, dagAction, System.currentTimeMillis()); + if(leaseAttemptStatus instanceof MultiActiveLeaseArbiter.LeaseObtainedStatus) { + dagTask = createDagTask(dagAction, + (MultiActiveLeaseArbiter.LeaseObtainedStatus) leaseAttemptStatus); + } + if (dagTask != null) { + break; // Exit the loop when dagTask is non-null + } + } catch (IOException e) { + //TODO: need to handle exceptions gracefully + throw new RuntimeException(e); + } + } + return dagTask; Review Comment: ```return createDagTask(...)``` would be more natural control flow, than is the `DagTask dagTask = null;`, the `break`, and finally `return dagTask` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
