[
https://issues.apache.org/jira/browse/GOBBLIN-1923?focusedWorklogId=883402&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-883402
]
ASF GitHub Bot logged work on GOBBLIN-1923:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 04/Oct/23 18:14
Start Date: 04/Oct/23 18:14
Worklog Time Spent: 10m
Work Description: umustafi commented on code in PR #3792:
URL: https://github.com/apache/gobblin/pull/3792#discussion_r1346279708
##########
gobblin-runtime/src/main/java/org/apache/gobblin/runtime/api/MysqlMultiActiveLeaseArbiter.java:
##########
@@ -110,9 +111,13 @@ protected interface CheckedFunction<T, R> {
private static final String CREATE_LEASE_ARBITER_TABLE_STATEMENT = "CREATE
TABLE IF NOT EXISTS %s ("
+ "flow_group varchar(" + ServiceConfigKeys.MAX_FLOW_GROUP_LENGTH + ")
NOT NULL, flow_name varchar("
+ ServiceConfigKeys.MAX_FLOW_GROUP_LENGTH + ") NOT NULL, " + "
flow_action varchar(100) NOT NULL, "
- + "event_timestamp TIMESTAMP(3) DEFAULT CURRENT_TIMESTAMP(3), "
- + "lease_acquisition_timestamp TIMESTAMP(3) NULL DEFAULT NULL, "
+ + "event_timestamp TIMESTAMP NOT NULL, "
+ + "lease_acquisition_timestamp TIMESTAMP NULL, "
Review Comment:
Yes I believe we'll have to drop that table. I will do that before
deploying.
Issue Time Tracking
-------------------
Worklog Id: (was: 883402)
Time Spent: 50m (was: 40m)
> Add retention thread for lease arbiter table
> --------------------------------------------
>
> Key: GOBBLIN-1923
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1923
> Project: Apache Gobblin
> Issue Type: Bug
> Components: gobblin-service
> Reporter: Urmi Mustafi
> Assignee: Abhishek Tiwari
> Priority: Major
> Time Spent: 50m
> Remaining Estimate: 0h
>
> Add retention to lease arbiter table so it does not grow unbounded. The table
> can be as large as O(number of flows) which may grow so large that
> reading/writing from this table becomes time consuming and slows down our
> throughput of obtaining and evaluating leases for launching flows.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
